Repository navigation
#50 - Use the PHP 8.3 to 8.5 functions through the Symfony polyfills, and configure Rector accordingly - #51
Merged
Merged
Conversation
…olyfills, and configure Rector accordingly * Require symfony/polyfill-php83, symfony/polyfill-php84 and symfony/polyfill-php85 (cleverage/process-bundle#299) * Rector: PHP 8.2 instead of 8.5 (the minimum version of the bundle), withPhpSets() without argument to add the polyfills set, remove the redundant LevelSetList::UP_TO_PHP_82 * No code change: no Rector rule applies, no manual replacement keeps an identical behaviour * Document the PHP version rule in CONTRIBUTING.md, update CHANGELOG.md Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50
Description
Same change as cleverage/process-bundle#299 (PR cleverage/process-bundle#300).
Changes
composer.json: requiresymfony/polyfill-php83,symfony/polyfill-php84andsymfony/polyfill-php85(^1.33).rector.php:->withPhpVersion(PhpVersion::PHP_82)instead ofPHP_85(the bundle supports PHP >= 8.2, Rector could introduce PHP 8.3+ functions without polyfill);->withPhpSets()without argument instead ofwithPhpSets(php82: true), which adds Rector'sPHP_POLYFILLSset (the rules using a newer function apply when the matching polyfill is required); remove the redundantLevelSetList::UP_TO_PHP_82and itsuse.rector --dry-runreports no change with the new configuration).src/has noreset()/current()/end()/key(), nojson_decode(), notrim(). Rejected candidates:Client::call()ucfirst($method)→mb_ucfirst(): not identical for non-ASCII method names (byte-based vs multibyte), and PHP method names built from it are byte strings anyway.SoapCallOptionsTraitforeach ($headers ...),RegisterClientsPassandCleverAgeSoapProcessExtensionloops: they build/register every element, no search or any/all test, soarray_find()/array_any()/array_all()don't apply.src/andtests/: none.CONTRIBUTING.md: new "PHP version" section.CHANGELOG.md: entry in "Latest".Checks
--prefer-lowest, PHP 8.2 with ext-soap): OK (34 tests, 101 assertions), the three polyfills installed.Requirements
Breaking changes
None: three new small dependencies (polyfills), no change of the minimum PHP version.
🤖 Generated with Claude Code