Repository navigation
#46 #45 - Give a code to the task and the transformer, class name as service id - #47
Merged
Merged
Conversation
… name as service id
- RequestTask: tagged { name: cleverage.task, code: soap_request }
(cleverage/process-bundle#91), referenced with "task: soap_request".
- RequestTransformer: tagged { name: cleverage.transformer, code: soap_request }
(the code returned by getCode()), loaded lazily by cleverage/process-bundle
5.4 (cleverage/process-bundle#276).
- Class name as service id for both, public with the container.private tag:
fetching them directly from the service container is deprecated since 3.3,
private in 4.0. Arguments, non-shared task and monolog.logger tags unchanged.
- Former ids cleverage_soap_process.task.request and
cleverage_soap_process.transformer.request: private deprecated aliases of
the class names (since 3.3, removed in 4.0).
- Tests: extension test for the ids, codes, container.private tags and the
deprecated aliases.
- Docs: code on the task reference page and template, examples switched to
"task: <code>", configuration paragraph in docs/index.md; CHANGELOG.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…test The transformer test instantiates RequestTransformer to compare the tag code with getCode(): with a coverage driver, the test was risky (code executed but not listed as covered or used). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #46, fixes #45: propagate cleverage/process-bundle#91 (PR cleverage/process-bundle#294) to the task of this bridge, and tag its transformer with its code for the lazy loading of cleverage/process-bundle#276 (PR cleverage/process-bundle#293). Deprecations introduced in 3.3, removal in 4.0.
Changes
soap_request(RequestTask),{ name: cleverage.task, code: soap_request }tag, so that the task is referenced withtask: soap_request(process-bundle 5.4 or later, where referencing a task by itsserviceis deprecated).RequestTransformertagged{ name: cleverage.transformer, code: soap_request }, the code returned by itsgetCode()(checked by process-bundle): with process-bundle 5.4 it is loaded lazily from the transformer locator instead of being instantiated eagerly byTransformerRegistry::addTransformer()(deprecated there withoutcode). The task and the transformer share thesoap_requestcode: no conflict, the registries are separate.monolog.loggertags unchanged). They are public, but fetching them directly from the service container is deprecated since 3.3 ({ name: container.private, package: cleverage/soap-process-bundle, version: '3.3' }); private in 4.0. Note: the transformer was previously private (its class-name alias had nopublic), it is now public with the samecontainer.privatedeprecation, as in process-bundle.cleverage_soap_process.task.request/cleverage_soap_process.transformer.request(private): deprecated aliases of the class names since 3.3 (The "cleverage_soap_process.task.request" service alias is deprecated, use the "soap_request" task code or the class name of the task instead. It will be removed in 4.0., and the same with "transformer code" / "class name of the transformer" for the transformer), removed in 4.0. They stay private. No other service definition referenced them.Transformer code), all the examples use the codes (soap_requestand the process-bundle taskstransformer,input_iterator,csv_reader,csv_writer,logger);index.md(codes, lazy loading of the transformer, service ids, deprecations).Requirement not changed yet:
cleverage/process-bundlestays^5.0, because 5.4 is not released (Composer could not resolve^5.4, the CI would fail). The change is harmless with process-bundle ≤ 5.3 (thecodeattributes of thecleverage.task/cleverage.transformertags are ignored there;container.privateand deprecated aliases are Symfony features). To raise to^5.4before releasing 3.3 (thetask:key of the documentation requires it).Checks
ContainerBuilder(ids,shared,public, tags, arguments, aliases and their deprecations).CleverAgeSoapProcessExtensionTest(class name as id, task non-shared,cleverage.task/cleverage.transformercode tags, transformer code equal togetCode(), public +container.private,monolog.loggertags and arguments, former ids private deprecated aliases with their message). Aftercomposer update: 34 tests OK, PHPStan, PHP-CS-Fixer, Rector OK,composer validate --strictOK.Requirements
Breaking changes
None: the former ids and the public access are only deprecated (3.3), removed in 4.0.
🤖 Generated with Claude Code