Repository navigation
#50 - CI: test the lowest dependencies, fix the lower bound of psr/log - #51
Merged
Merged
Conversation
Add a PHP 8.2 + lowest job to the test workflow: it installs the lowest versions allowed by composer.json (composer update --prefer-lowest --prefer-stable). With the lowest set, psr/log resolved to 1.1.0 and the tests stopped on a fatal error: the test logger declares the typed log() signature of psr/log 2/3, as do the loggers of cleverage/process-bundle 5.0 (Logger\AbstractLogger), both incompatible with psr/log 1. Raise psr/log to ^2 || ^3. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #50: add a CI job testing the lowest versions allowed by
composer.json, and fix the lower bound it revealed. Same change as cleverage/process-bundle#274 (PR cleverage/process-bundle#287).Changes
.github/workflows/test.yml: new matrix entry, PHP 8.2 (lowest supported) withdependencies: lowest(ramsey/composer-installrunscomposer update --prefer-lowest --prefer-stable).psr/log^2 || ^3(was^1 || ^2 || ^3, resolved to 1.1.0 with the lowest set): the test logger ofRequestTaskTestdeclareslog($level, string|\Stringable $message, array $context = []): void, incompatible withpsr/log1:cleverage/process-bundle5.0 loggers have the same signature (Logger\AbstractLogger, parent ofTaskLogger/ProcessLogger): loading them withpsr/log1 gives the same fatal error, so the bundle could not run withpsr/log1 anyway.Note: the lowest set resolves
monolog/monolog2.3.3 throughcleverage/process-bundle5.0, whoseLogger\*ProcessortypeMonolog\LogRecord(Monolog 3). This bundle does not use Monolog directly and no test is affected; it is fixed in cleverage/process-bundle#287 (monolog/monolog^3).Checks
composer update --prefer-lowest --prefer-stable(cleverage/process-bundle5.0, Symfony 6.4.0,symfony/http-client6.4.15,symfony/http-client-contracts3.4.2,symfony/deprecation-contracts2.5.0,psr/log2.0.0, PHPUnit 11.5): 33 tests OK. Before the fix: fatal error above.composer update: 33 tests OK, PHPStan OK,composer validate --strictOK.Requirements
Breaking changes
None in practice: the removed
psr/log1 versions could not work (fatal error when loading thecleverage/process-bundleloggers), andpsr/log1 support was only declared in the unreleased #44.🤖 Generated with Claude Code