Repository navigation
#327 - ContextualOptionResolver: quote the context keys in the pattern of the placeholders - #328
Open
njoubert-cleverage wants to merge 1 commit into
Open
njoubert-cleverage wants to merge 1 commit into
njoubert-cleverage wants to merge 1 commit into
Conversation
…n of the placeholders, nothing to replace with an empty context Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #327.
preg_quote((string) $key, '/')) in the pattern of the{{ key }}placeholders: a key containing/made the pattern invalid (every string option of every task failed, even without placeholder), and a key containing a regex character matched other placeholders (x.matched{{ x }}).{{ }}matched an empty key).ContextualOptionResolverTest(the class had no dedicated test).Requirements
Breaking changes
None: only keys containing regex characters change behaviour, they did not work.
🤖 Generated with Claude Code