Repository navigation
#311 - Deprecate DataQueueEventListener - #316
Merged
Merged
Conversation
- The cleverage_process.event_listener.data_queue service is deprecated (setDeprecated(), notice when it is injected or fetched) and DataQueueEventListener is marked @deprecated: it keeps a copy of the ProcessState of every cleverage_process.data_queue event in memory, without limit. Both will be removed in v6.0. - Tests, documentation (event_dispatcher task) and CHANGELOG updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #311.
cleverage_process.event_listener.data_queue(config/services/event.yaml):deprecated(packagecleverage/process-bundle, version5.4): a notice is triggered when the service is instantiated, i.e. injected, fetched, or called because an application dispatchescleverage_process.data_queuewith anevent_dispatchertask. Nothing in the bundles dispatches this event.DataQueueEventListener:@deprecated. It keeps acloneof theProcessStateof every event in memory, without limit, for the lifetime of the container ("Used mostly for testing purpose").event_dispatcherreference page).event_dispatcherreference page. CHANGELOG.Tests:
CleverAgeProcessExtensionTest::testTheDataQueueListenerIsDeprecated().Checked in the container (978 tests): highest dependencies (PHP 8.5, Symfony 8.1), lowest dependencies (PHP 8.2, Symfony 6.4.0), Symfony 6.4.48 on PHP 8.2 and 8.5, Symfony 7.4: no deprecation, no risky test (with pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK.
Requirements
Breaking changes
None. New deprecation (5.4): the
cleverage_process.event_listener.data_queueservice andDataQueueEventListener, removed in v6.0.🤖 Generated with Claude Code