Repository navigation
#312 - Read-only interfaces for the process manager and the registries - #315
Merged
Merged
Conversation
- New ProcessManagerInterface (execute()), ProcessConfigurationRegistryInterface (getProcessConfiguration(), getProcessConfigurations(), hasProcessConfiguration()), TransformerRegistryInterface (getTransformer(), getTransformers(), hasTransformer(), not the deprecated addTransformer()) and TaskRegistryInterface (getTask()), implemented by the existing classes. - Autowiring aliases for the four interfaces. - Tests, documentation (advanced workflow) and CHANGELOG updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #312.
ProcessManager,ProcessConfigurationRegistryandTransformerRegistryare@final since 5.4(#279) andTaskRegistryisfinal: without interfaces, an application could not decorate or replace them oncefinal. New read-only interfaces, implemented by the existing classes:Manager\ProcessManagerInterfaceexecute()cleverage_process.manager.processRegistry\ProcessConfigurationRegistryInterfacegetProcessConfiguration(),getProcessConfigurations(),hasProcessConfiguration()cleverage_process.registry.process_configurationRegistry\TransformerRegistryInterfacegetTransformer(),getTransformers(),hasTransformer()cleverage_process.registry.transformerRegistry\TaskRegistryInterfacegetTask()cleverage_process.registry.taskgetProcessHistory(),getTaskConfiguration(),reset()), the deprecatedTransformerRegistry::addTransformer().ProcessConfigurationRegistry::getProcessConfigurations(): PHPDocarray<string, ProcessConfiguration>(indexed by process code, as returned).Tests:
CleverAgeProcessExtensionTest::testServicesCanBeAutowiredByInterface().Checked in the container (978 tests): highest dependencies (PHP 8.5, Symfony 8.1), lowest dependencies (PHP 8.2, Symfony 6.4.0), Symfony 6.4.48 on PHP 8.2 and 8.5, Symfony 7.4: no deprecation, no risky test (with pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK.
Requirements
Breaking changes
None: new interfaces implemented by the existing classes.
🤖 Generated with Claude Code