v6.0: remove the deprecated code #292

Description

Remove, in v6.0, the code deprecated during v5 (and before), with its BC layers. Inventory on main @ b38efed (trigger_deprecation(), @deprecated, #[\Deprecated], deprecated options / configuration keys); add to this list every new deprecation until v6.0.

Runtime deprecations (trigger_deprecation())

• Task registry fallbacks (Fetch tasks from a service locator instead of the service container (v5 step of #114) #275, since 5.4) — also makes Tasks services should not be public #114 complete:

  • ProcessManager: make the ?TaskRegistry $taskRegistry argument required, remove the $container argument and the fallback on the service container; ProcessHelpCommand (Bundle best practices: residues (generic transformers autowiring, help command container, deprecation notices) #305): accept only a TaskRegistry as second argument (no more ContainerInterface), remove the deprecated $container property (ProcessManager.php, ProcessHelpCommand.php);
  • TaskRegistry: remove the fallback on the service container (second constructor argument, '@service_container' in config/services/registry.yaml);
  • remove the service key of the task configurations (deprecated since 5.4 by Reference the tasks by a code in the process configurations (task key, #[AsTask]) #91, setDeprecated() in Configuration): task: <code> only;
  • make the tasks and transformers of the bundle private: remove the public: true and the container.private tag (fetching them directly from the service container is deprecated since 5.4 by Reference the tasks by a code in the process configurations (task key, #[AsTask]) #91) of config/services/task.yaml / transformer.yaml, and the public: true of the TaskInterface autoconfiguration (DependencyInjection: add FQCN aliases and autoconfiguration for TaskInterface and TransformerInterface #272) with the internal PublicTaskDeprecationCompilerPass (Bundle best practices: residues (generic transformers autowiring, help command container, deprecation notices) #305, deprecates the direct access to the application tasks made public only by this autoconfiguration); same for the tasks of the bridge bundles.

• Initialization failure (An exception thrown by initialize() does not abort the process: upstream tasks run, or the process succeeds #222, since 5.1): an exception thrown by InitializableTaskInterface::initialize() must fail the process before executing any task (ProcessManager::initialize()).

• EventDispatcherTask (EventDispatcherTask ignores the event_name option #189, since 5.1): with event_name set, stop dispatching the event under its class name too (EventDispatcherTask.php, doc event_dispatcher_task.md).

• MappingTransformer ([Transformer] We should throw an exception when we try to transform an invalid index #117, since 5.2): a non simple target property of an array destination (e.g. address.city) throws an \UnexpectedValueException instead of creating a literal key (MappingTransformer.php, doc mapping_transformer.md).

• CallbackTransformer (since 2.0.4): remove the additional_parameters option (use right_parameters) (CallbackTransformer.php, doc callback_transformer.md).

• TaskConfiguration::getErrors() (since 2.0.4): remove the method (use getErrorOutputs()), and the @deprecated $logErrors property (TaskConfiguration.php).

• errors task configuration key (notice since 5.4, Bundle best practices: residues (generic transformers autowiring, help command container, deprecation notices) #305, setDeprecated()): deprecated alias of error_outputs (Configuration.php, ProcessConfigurationRegistry.php, doc 02-task_definition.md).

• CheckSerializerCompilerPass (CheckSerializerCompilerPass: do not fail the container compilation when the serializer is disabled #278, notice since 5.4, Bundle best practices: residues (generic transformers autowiring, help command container, deprecation notices) #305): no longer registered, remove the class.

• Unknown task error_strategy (Configuration tree: validate the task error_strategy, boolean public, describe the nodes #310, notice since 5.4 when the container is compiled): reject any value other than skip / stop (enumNode, null allowed for the default_error_strategy), remove CleverAgeProcessExtension::checkErrorStrategies() (Configuration.php, CleverAgeProcessExtension.php, doc 02-task_definition.md); the Unknown error strategy exception of ProcessManager::processExecution() becomes unreachable.

• DataQueueEventListener (DataQueueEventListener: deprecate it (unbounded queue, nothing dispatches its event) #311, since 5.4, deprecated service): remove the cleverage_process.event_listener.data_queue service (config/services/event.yaml) and the class (DataQueueEventListener.php), doc event_dispatcher_task.md.

• Kernel arguments of the process tasks (Process tasks: no more kernel injection, sub-process buffer in the temporary directory #318, since 5.4): CommandRunnerTask, ProcessLauncherTask and SubprocessInstance only accept the paths (project directory, console) as strings, no more KernelInterface; remove the deprecated $kernel properties and SubprocessInstance::$logDir (CommandRunnerTask.php, ProcessLauncherTask.php, SubprocessInstance.php).

• Eager transformer registration (TransformerRegistry: lazy-load transformers through a service locator indexed by code #276, since 5.4) — v6 step tracked by TransformerRegistry: require the code tag attribute and remove eager transformer registration (v6 step of #276) #280: the code attribute of the cleverage.transformer tag (or #[AsTransformer]) becomes required, remove TransformerRegistry::addTransformer() and the eager registration of the transformers tagged without code (TransformerRegistry.php, TransformerLocatorCompilerPass.php).

• RegistryCompilerPass (TransformerRegistry: lazy-load transformers through a service locator indexed by code #276, notice since 5.4): no longer registered, remove the class.

Deprecated without runtime notice

• ProcessLauncherTask::process_options: deprecated option, any non-empty value already throws: remove it (doc process_launcher_task.md).
• TransformerInterface::getCode() (TransformerRegistry: lazy-load transformers through a service locator indexed by code #276, @deprecated PHPDoc since 5.4, no runtime notice possible for an interface method): remove it from the interface, the code being given by the tag code attribute / #[AsTransformer] (with TransformerRegistry: require the code tag attribute and remove eager transformer registration (v6 step of #276) #280) (TransformerInterface.php).

For each item

Remove the code and the tests of the deprecated behaviour, update the reference documentation (Notes / Deprecated mentions), and list the change in the CHANGELOG and an UPGRADE-6.0.md.

Note: the bridge bundles have their own deprecations, for their next major version (e.g. Client::geUri() in rest, LogRecord::contextIsEmpty() in ui).

Requirements

• Documentation updates
  • Reference
  • Cookbooks
  • Changelog
• Unit tests

Breaking changes

Major: removal of the deprecated code (v6.0).