Skip to content

#51 - Give a code to the tasks, class name as service id - #52

Merged
njoubert-cleverage merged 1 commit into
mainfrom
51
Oct 15, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
51

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #51: propagate cleverage/process-bundle#91 (PR cleverage/process-bundle#294) to this bridge. Deprecations introduced in 3.3, removal in 4.0.

Changes

  • Codes: flysystem_file_fetch (FileFetchTask), flysystem_list_content (ListContentTask) and flysystem_remove_file (RemoveFileTask), cleverage.task tag, so that the tasks are referenced with task: flysystem_file_fetch (process-bundle 5.4 or later, where referencing a task by its service is deprecated).
  • Service ids: the class names, as in process-bundle (definitions non-shared, arguments — logger, !tagged_locator { tag: 'flysystem.storage', index_by: 'storage' } — and monolog.logger tag unchanged). They stay public, but fetching them directly from the service container is deprecated since 3.3 ({ name: container.private, package: cleverage/flysystem-process-bundle, version: '3.3' }): Accessing the "…" service directly from the container is deprecated, use dependency injection instead.; private in 4.0. The references of the container (process-bundle task locator) use the private service, without deprecation.
  • Former ids cleverage_flysystem_process.task.file_fetch / cleverage_flysystem_process.task.list_content / cleverage_flysystem_process.task.remove_file (released since 3.0, private): deprecated aliases of the class names since 3.3 (The "cleverage_flysystem_process.task.file_fetch" service alias is deprecated, use the "flysystem_file_fetch" task code or the class name of the task instead. It will be removed in 4.0.), removed in 4.0. They stay private, as before. No other service definition of the bundle referenced them.
  • Docs: the code on the reference page of each task (and in the template), all the examples of the cookbooks and reference pages use the codes (flysystem tasks and process-bundle tasks, 25 references, template included); index.md (codes, service ids, deprecations).
  • CHANGELOG (Latest).

Requirement not changed yet: cleverage/process-bundle stays ^5.0, because 5.4 is not released (Composer could not resolve ^5.4, the CI would fail). The change is harmless with process-bundle ≤ 5.3 (the cleverage.task tag is ignored there; container.private and deprecated aliases are Symfony features). To raise to ^5.4 before releasing 3.3 (the task: key of the documentation requires it).

Checks

  • Container built from the extension (docker): the 3 class-name definitions are public, non-shared, with their cleverage.task code, monolog.logger and container.private tags; the 3 former ids are private aliases with their deprecation.
  • Tests: CleverAgeFlysystemProcessExtensionTest (class name as id, non-shared, storages locator, code, public + container.private, former ids private deprecated aliases with their message; every task definition is tested). After composer update: 35 tests OK, PHPStan, PHP-CS-Fixer, Rector OK, composer validate --strict OK.
  • Demo project check to be done separately.

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

None: the former ids and the public access are only deprecated (3.3), removed in 4.0.

🤖 Generated with Claude Code

Give a code to the tasks (cleverage/process-bundle#91), prefixed by the
bridge name: flysystem_file_fetch (FileFetchTask), flysystem_list_content
(ListContentTask) and flysystem_remove_file (RemoveFileTask), tagged
{ name: cleverage.task, code: <code> } to be referenced with
`task: <code>` (cleverage/process-bundle 5.4 or later).

The class name is now the service id (public, non-shared, with the
container.private tag: fetching the tasks directly from the service
container is deprecated since 3.3, private in 4.0). The former ids
cleverage_flysystem_process.task.* are kept as private aliases,
deprecated since 3.3, removed in 4.0.

Update the extension test, the reference pages (task code), the
template, the cookbooks and reference examples (task: <code>), the
index and the CHANGELOG.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage merged commit 80819a6 into main Oct 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give a code to the tasks (process-bundle#91), class name as service id

1 participant