Repository navigation
#49 - CI: test the lowest dependencies, require psr/log ^2|^3 - #50
Merged
Merged
Conversation
Add a "PHP 8.2 + lowest" job to the test workflow: it installs the lowest
versions allowed by composer.json (--prefer-lowest --prefer-stable) on the
lowest supported PHP version.
This set revealed a wrong lower bound: with psr/log 1.1.0,
cleverage/process-bundle 5.0 (and the test logger) declare the typed
LoggerInterface::log() signature, which is a fatal error ("Declaration of
CleverAge\ProcessBundle\Logger\AbstractLogger::log(...) must be compatible
with Psr\Log\LoggerInterface::log($level, $message, array $context = [])").
Require psr/log ^2|^3, as cleverage/process-bundle now does.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #49: add a CI job testing the lowest versions allowed by
composer.jsonon PHP 8.2, and fix the lower bound it reveals. Same change as cleverage/process-bundle#274 (PR cleverage/process-bundle#287).Changes
.github/workflows/test.yml: newPHP 8.2 + lowest + normaljob (dependencies: lowest, i.e.composer update --prefer-lowest --prefer-stable).psr/log:^1|^2|^3→^2|^3. The lowest set resolvedpsr/log1.1.0, and PHPUnit crashed withPHP Fatal error: Declaration of CleverAge\ProcessBundle\Logger\AbstractLogger::log($level, Stringable|string $message, array $context = []): void must be compatible with Psr\Log\LoggerInterface::log($level, $message, array $context = [])(first hit in the test logger ofRemoveFileTaskTest, and loadingcleverage/process-bundle5.0's ownProcessLoggerfails the same way).cleverage/process-bundlenow requirespsr/log^2|^3too.Checks
composer update --prefer-lowest --prefer-stable(cleverage/process-bundle 5.0, league/flysystem 3.35.3, league/flysystem-bundle 3.0.0, psr/log 2.0.0, monolog/monolog 2.3.3, Symfony 6.4.0, PHPUnit 11.5.50): 35 tests OK.composer update: 35 tests OK, PHPStan OK,composer validate --strictOK.Requirements
Breaking changes
None in practice:
psr/log1 could not work,cleverage/process-bundle5.x already crashes with it (fatal error on its logger classes).🤖 Generated with Claude Code