Skip to content

test(expo): upgrade e2e to 0.22.0 - #10556

Merged
mikepitre merged 2 commits into
mainfrom
mike/e2e-0.22
Oct 30, 2026
Merged

mikepitre merged 2 commits into
mainfrom
mike/e2e-0.22

Conversation

@mikepitre

@mikepitre mikepitre commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Upgrades the Expo e2e tests from e2e 0.18.0 to 0.22.0. e2e 0.21.3 added test filters, which we want so that PRs run only the e2e tests a change can affect. That comes in a later PR.

  • integration/expo-native moves @clerk/internal-mobile-e2e to clerk/internal-mobile-e2e#8, which upgrades e2e and reads failure pages, failure screens and screenshots from e2e 0.22's results/ directory.
  • verify-e2e.yml uploads e2e*/results instead of e2e*/failures and e2e*/artifacts, which e2e 0.22 no longer writes.
  • verify-clerk-expo/SKILL.md names the new failure-page path, .verify/runs/<run-id>/e2e/results/<test>/trace.md.
  • Empty changeset, since no package changes.

Merge this after clerk/internal-mobile-e2e#8. The pin is that PR's branch commit 9284526. internal-mobile-e2e lands PRs with merge commits, so the pinned commit becomes part of its main history and needs no repin. If clerk/internal-mobile-e2e#8 is squash-merged instead, the pin has to move to the squash commit.

How to test:

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

🤖 Generated with Claude Code

mikepitre and others added 2 commits October 30, 2026 15:34
Moves the @clerk/internal-mobile-e2e pin to the commit that upgrades
e2e from 0.18.0 to 0.22.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moves the @clerk/internal-mobile-e2e pin to the commit that reads e2e
0.22's results directory. e2e now writes failure pages, failure screens
and screenshots under e2e*/results instead of e2e*/failures and
e2e*/artifacts, so the evidence upload and the skill's failure-page path
follow it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dc91a80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 30, 2026 8:28pm UTC
swingset Ready Ready Preview Oct 30, 2026 8:28pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between a7e5619 and dc91a80.

Files ignored due to path filters: 1
  • integration/expo-native/package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 4
  • .changeset/quiet-tests-climb.md
  • .claude/skills/verify-clerk-expo/SKILL.md
  • .github/workflows/verify-e2e.yml
  • integration/expo-native/package.json
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The Expo E2E dependency pin now references a different commit. The workflow uploads each run’s results directory, and the skill documentation points to per-test trace.md files. The changeset file now contains an empty YAML front matter block.

Estimated code review effort: 2 (Simple) | ~8 minutes

Possibly related PRs

  • clerk/javascript#10400: Updates the same E2E dependency pin and relates to evidence posting and path behavior.

Suggested reviewers: wobsoriano

Merge Risk: Minimal · up to dc91a

The repository-side E2E evidence updates are consistent and ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: upgrading the Expo E2E tests to version 0.22.0.
Description check Passed The description directly explains the E2E upgrade, dependency pin, evidence path changes, workflow updates, testing results, and merge dependency.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10556

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10556

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10556

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10556

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10556

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10556

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10556

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10556

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10556

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10556

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10556

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10556

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10556

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10556

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10556

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10556

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10556

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10556

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10556

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10556

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10556

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10556

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10556

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10556

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10556

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10556

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10556

commit: dc91a80

@mikepitre
mikepitre marked this pull request as ready for review October 30, 2026 21:16
@mikepitre
mikepitre enabled auto-merge (squash) October 30, 2026 21:27
@mikepitre
mikepitre requested a review from wobsoriano October 30, 2026 21:28
@mikepitre
mikepitre merged commit ccea971 into main Oct 30, 2026
98 checks passed
@mikepitre
mikepitre deleted the mike/e2e-0.22 branch October 30, 2026 21:30

This branch was successfully deployed

2 active deployments
Preview – swingset — dc91a803 Deployed Oct 30, 2026 by vercel[bot]
Preview – clerk-js-sandbox — dc91a803 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants