Skip to content

refactor(mosaic): make the fullscreen profile a real dialog variant - #10179

Merged
prestonwebdev merged 5 commits into
prestonwebdev/full-screen-profile-modefrom
carp/fullscreen-profile-fixes
Oct 9, 2026
Merged

prestonwebdev merged 5 commits into
prestonwebdev/full-screen-profile-modefrom
carp/fullscreen-profile-fixes

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

Stacked on #10176. Restructures the fullscreen profile dialog without changing how it looks or the variant='fullscreen' API.

  • Width belongs to the Profile. The fullscreen Profile sizes itself with inline-size: 100cqi, and the popup keeps fit-content like every other variant. The popup's fullscreen width: 100% rule is removed.
  • fullscreen is a real dialog variant. It has its own entry in each variant table (variants, viewportVariants, trackVariants, backdropMotion, popupMotion, closeInsets), sharing the profile values through constants. Its track entry removes the gap around the popup. surfaceOf() and the extra trackVariants.fullscreen patch are gone. The places that care whether a dialog holds a profile use holdsProfile(variant).
  • One dismiss decision in Profile. Root resolves 'back' | 'corner' | 'none' once and shares it through context, replacing the separate fullscreen && !compact and navLayout === 'column' checks.
  • layoutFullscreen overrides layoutInDialog with only borderRadius: 0 and boxShadow: 'none', instead of copying it.
  • Class-probe tests removed for the fullscreen track and Profile width; the behavior tests stay.

One behavior change: a fullscreen dialog with role="alertdialog" no longer shows the Back button, matching how a profile alert dialog shows no corner close.

Not included: safe-area insets. On notched devices with viewport-fit=cover, the fullscreen and compact profile dialogs place controls under the notch and home indicator. That also affects the plain profile dialog on main, so it will be a separate PR.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 9, 2026 7:52pm UTC
swingset Ready Ready Preview Oct 9, 2026 7:52pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c47b18d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: b50ae5dd-1126-4853-a0d1-5920f61dd71f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@prestonwebdev
prestonwebdev merged commit 056beaf into prestonwebdev/full-screen-profile-mode Oct 9, 2026
10 checks passed
@prestonwebdev
prestonwebdev deleted the carp/fullscreen-profile-fixes branch October 9, 2026 21:20

This branch was successfully deployed

2 active deployments
Preview – swingset — c47b18d0 Deployed Oct 9, 2026 by vercel[bot]
Preview – clerk-js-sandbox — c47b18d0 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants