Repository navigation
refactor(mosaic): make the fullscreen profile a real dialog variant - #10179
prestonwebdev merged 5 commits into
Conversation
…he profile dismiss once
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c47b18d The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
056beaf
into
prestonwebdev/full-screen-profile-mode
Description
Stacked on #10176. Restructures the fullscreen profile dialog without changing how it looks or the
variant='fullscreen'API.inline-size: 100cqi, and the popup keepsfit-contentlike every other variant. The popup's fullscreenwidth: 100%rule is removed.fullscreenis a real dialog variant. It has its own entry in each variant table (variants,viewportVariants,trackVariants,backdropMotion,popupMotion,closeInsets), sharing the profile values through constants. Its track entry removes the gap around the popup.surfaceOf()and the extratrackVariants.fullscreenpatch are gone. The places that care whether a dialog holds a profile useholdsProfile(variant).'back' | 'corner' | 'none'once and shares it through context, replacing the separatefullscreen && !compactandnavLayout === 'column'checks.layoutFullscreenoverrideslayoutInDialogwith onlyborderRadius: 0andboxShadow: 'none', instead of copying it.One behavior change: a fullscreen dialog with
role="alertdialog"no longer shows the Back button, matching how a profile alert dialog shows no corner close.Not included: safe-area insets. On notched devices with
viewport-fit=cover, the fullscreen and compact profile dialogs place controls under the notch and home indicator. That also affects the plainprofiledialog onmain, so it will be a separate PR.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change