Repository navigation
Candidate deephaven-fixes head with #31 (do not merge) - #33
Merged
Merged
Conversation
When a 200 response body was not valid JSON, BaseClient._get logged the decode error and returned [], and _paginate_iter did the same. A get_* call returned [] instead of a model, and a list_* call yielded nothing if the first page was bad, or stopped early, without error, if a later page was bad. Callers silently got missing data. _decode now raises BadResponse with the response status and the first 200 bytes of the body, and _get and _paginate_iter let it propagate.
, #31) The tree of this commit is exactly the tree of integrate/series-2026-10-25 (its second parent): origin/master with the 20 preview PRs #4, #7-#24 and #31 merged in dependency order, at their current heads. It adds #31 (raise BadResponse when a response is not valid JSON) to the series. The branch moves forward by this merge rather than a reset, so every commit a lockfile recorded stays reachable.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Owner
Author
|
GitHub marked this PR as merged on its own: deephaven-fixes was fast-forwarded to its head, a16a55c, by a push. No one merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI check only. Do not merge. The head is the commit that
deephaven-fixeswill fast-forward to. Its tree equals the tree ofintegrate/series-2026-10-25, and its parents are the currentdeephaven-fixes(46d13cc) and that integration head. This PR runs the required checks against that exact SHA.