Repository navigation
concat: follow the inputs' Zarr version - #43
Merged
Merged
Conversation
Fixes #36. With no --zarr-format, concat wrote whatever zarr-python defaults to (v3), so two v2 inputs came out v3, contrary to the docs. It now uses the version its Zarr inputs share; h5ad inputs do not count, and inputs of both versions still get v3. The flag table in COMMANDS.md gains --zarr-format and --chunk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36. Stacked on #42. Merge that first; this PR then retargets to
main.With no
--zarr-format,concatwrote whatever zarr-python defaults to, which is v3. So two v2 inputs came out as v3, which contradictsdocs/COMMANDS.md("New Zarr stores follow the source store's version").What changed
concatnow follows the version its Zarr inputs share:--zarr-formatstill overrides this. The--helptext now states the default, and theconcatflag table inCOMMANDS.mdgains--zarr-formatand--chunk.Tests
test_concat_follows_the_inputs_zarr_versioncovers the four cases in the table. The v2 cases fail onmain.test_concat_zarr_format_overrides_the_inputscovers the override.🤖 Generated with Claude Code