Skip to content

Adapt tests for Windows compatibility - #337

Merged
GagaLP merged 1 commit into
masterfrom
fix/windows-testing
Aug 10, 2026
Merged

GagaLP merged 1 commit into
masterfrom
fix/windows-testing

Conversation

@GagaLP

@GagaLP GagaLP commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This PR is a follow-up to PR #336 and fixes several tests to improve Windows support.

The changes affect task, command, and instruction graph printing tests as well as live_executor starvation/active-time tests:

  • The task, command, and instruction graph printing tests compare exact output strings, which depend on the iteration order of std::unordered_map. Since MSVC's standard library uses a different iteration order, these tests fail on Windows even though graph construction is correct. The tests are disabled for now until a more robust graph comparison method is available.
  • The live_executor starvation/active-time test tolerance is now platform-dependent, using 20ms on Windows (where the previous tolerance was too strict) and 10ms on other platforms, instead of increasing the tolerance globally.

@GagaLP
GagaLP requested a review from PeterTh July 14, 2026 16:05
@github-actions

Copy link
Copy Markdown

Check-perf-impact results: (ae6918621b46271c2f10d6eb978fe95d)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@PeterTh PeterTh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request, looks good otherwise.

Comment thread test/print_graph_tests.cc Outdated
@GagaLP
GagaLP force-pushed the fix/windows-testing branch from c77625b to a38b899 Compare August 3, 2026 15:33
@coveralls

coveralls commented Aug 3, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 31110403246

Coverage remained the same at 95.067%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 7261
Covered Lines: 7156
Line Coverage: 98.55%
Relevant Branches: 3686
Covered Branches: 3251
Branch Coverage: 88.2%
Branches in Coverage %: Yes
Coverage Strength: 1896846.82 hits per line

💛 - Coveralls

@GagaLP
GagaLP force-pushed the fix/windows-testing branch 2 times, most recently from aa58bfd to 78fb834 Compare August 6, 2026 14:21
@GagaLP
GagaLP force-pushed the fix/windows-testing branch from 78fb834 to 2d4a452 Compare August 6, 2026 16:05
@GagaLP
GagaLP merged commit ffe21ec into master Aug 10, 2026
4 of 6 checks passed
@GagaLP
GagaLP deleted the fix/windows-testing branch August 10, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants