Repository navigation
fix: patch the vite advisory in the test tooling - #88
Merged
Merged
Conversation
pnpm audit --audit-level=high now fails on main. A high advisory (GHSA-587h-7wmj-h5pm) appeared for vite 8.2.0 through 8.2.3: a launch-editor existence check can be bypassed on Windows. vite reaches this repository only through Vitest and the Cloudflare Vitest plugin. The published package has no runtime dependencies. Vitest 4 lists vite as a peer, so pnpm kept the old 8.2.1 even with an override. vite is now a direct development dependency at 8.3.4, the newest patched release that is at least 10 days old. pnpm audit at the high level passes, and pnpm test, test:cloudflare, check:cloudflare, pack:check, and test:package pass.
 [Low impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds
Reviews (1) · Last reviewed commit: "fix: patch the vite advisory in the test..." · Reviewed by Greptile |
cardmagic
added a commit
that referenced
this pull request
Oct 22, 2026
The vite advisory fix (#88) ran pnpm add while pnpm ignored the release age, so the lockfile took rolldown 1.2.15, postcss 8.5.31, and @oxc-project/types 0.155.0, published one to three days earlier. With the release age on, a frozen install rejects these 18 entries. The lockfile now starts again from the one before #88 and resolves vite ^8.3.4 under the release age: vite 8.3.4, rolldown 1.2.13, and postcss 8.5.29. A frozen install, pnpm audit at the high level, pnpm test, and test:cloudflare pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm audit --audit-level=highfails onmain(CI run 39802922572, job "quality") since a high advisory appeared for vite 8.2.0 through 8.2.3: GHSA-587h-7wmj-h5pm, alaunch-editorexistence check that can be bypassed on Windows.@cloudflare/vitest-plugin > vitest > @vitest/mocker > vite. The published package has no runtime dependencies, so users are not affected.pnpm-workspace.yaml. vite is now a direct development dependency,^8.3.4, locked at 8.3.4: the newest patched release that is at least 10 days old (published 2026-10-08). 8.3.5 is one day old.Note
pnpm config get minimumReleaseAgereturnsundefinedwith pnpm 11.11: pnpm no longer reads theminimumReleaseAge = 10 daysline in.npmrc. Without care, a plainpnpm addwould have taken vite 8.3.5. That fix is not in this pull request.Checks
pnpm audit --audit-level=highpasses (2 moderate advisories remain, below the CI threshold).pnpm run check,pnpm test(709 passed),pnpm run test:cloudflare(61 passed after a build),check:cloudflare,pack:check, andtest:packagepass.pnpm peers checkreports no issues.