Repository navigation
chore(agents): CI failures reach fix runs; audit runs the comment review; fewer pushes; Stryker failures say why - #452
Merged
Merged
Conversation
…s; audit runs the comment review; fewer pushes; Stryker failures say why
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the #437 delivery (PR #449). Each change targets a class of problem, not that run's particular defects.
.agents/scripts/ci-failures.mjs <pr>prints the failed tests of the newest finished run of each workflow on the branch.deliverruns it before every review round and fix run, and puts its failures into the fix run'sfixes. Implementers use it for theirci:value.comment-reviewerbrief now lives in its own definition, so the reviewer and the implementer's audit spawn it the same way. Audit deletes what it flags instead of rewording. The claims review now judges only whether a comment is true. Whether a comment should exist is the comment review's call.path:linethat shows it. Fixes that brought in new false claims cost rounds in Core knows physical devices: the device union, its state machine, and every virtual-only path leaves them alone #436 and simlock device add / remove: an admin enrolls and unenrolls physical devices #437.mutate.mjsprints the last lines of Stryker's error output at the end and exits 2. Before, it exited 1, and the hook then printed "Mutants survived". A crash on feat(enrollment): simlock device add / remove enroll and unenroll physical devices #449 couldn't be reproduced at the same commit, and its cause was lost to| tail.Tests:
src/ci-failures.test.ts(new) andsrc/mutate.test.ts(one new case). Every check was probed by breaking the script.