Repository navigation
fix: declare Node.js require(esm) engine range - #470
Merged
Merged
Conversation
(cherry picked from commit e7f60eb)
kraenhansen
marked this pull request as ready for review
October 11, 2026 20:40
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #452 by @huytdps13400, targeting
maininstead ofnext— the change doesn't depend on the Hermes work, and #452 carries the pre-rebasenexthistory. The commit is cherry-picked unchanged, keeping its author.Declares
engines.nodeforreact-native-node-apias>=20.19.0 <21 || >=22.12.0— the versions that canrequire()ESM — so package managers warn before the CLI loads its ESM dependencies on an incompatible runtime.Test plan
pnpm install,pnpm run build,pnpm run lintreact-native-node-apiunit tests (62 pass)🤖 Generated with Claude Code