Implement napi_is_buffer #68

Activity

1. kraenhansen

   added a parent issue on May 14, 2025

   • Implement Node-API runtime functions ☂️ #56
2. kraenhansen

   added

   Node-API v1

   on May 14, 2025
3. mani3xis

   self-assigned this

   on May 14, 2025
4. mani3xis commented on May 16, 2025

   

   mani3xis

   on May 16, 2025

   Contributor

   More actions

   FYI: I will copy the implementation that I've used for my node-sodium demo.
5. paradowstack

   assigned

   paradowstack

   and unassigned

   mani3xis

   on Jul 10, 2025
6. kraenhansen commented on Aug 12, 2026

   

   kraenhansen

   on Aug 12, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Implemented in packages/host/cpp/RuntimeNodeApi.cpp, covered by packages/node-addon-examples/tests/buffers (a port of Node's test_buffer).

   One fidelity note for whoever picks up #171: the host's napi_is_buffer answers true for any ArrayBuffer or TypedArray, which is looser than Node — and looser than Hermes' own implementation (API/napi/hermes_napi_buffer.cpp, adopted in #372), which only accepts a Uint8Array. The host's definition currently shadows Hermes' in the generated injector, so tightening this is a matter of dropping the shim.

   ---

   Generated by Claude Code
7. kraenhansen

   closed this as completedon Aug 12, 2026