Repository navigation
feat(ui): move workspace controls to a bar under the simulators - #12
Merged
Merged
Conversation
The tools and platform menus sat in the first visible simulator's header beside its device controls. In the sidebar panel they now share one full-width bar under the simulators, tools on the left and platforms on the right, with menus opening upward. Fullscreen and a layout without visible platforms keep the bar above the tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the workspace's tools menu and platform menu out of the simulator header into their own bar.
justify-between). When both platforms are visible, it spans both simulators. Both menus open upward.nav. The oldml-autoand per-placement menu alignment conditionals are gone, andSimulatorViewno longer takes atoolbarprop. The device picker now starts at the left of the simulator header.docs/devices.mddescribes where the two menus are.The final commit bumps the version to 0.1.141.
Telemetry
None. This only moves existing controls; surface and layout attribution are unchanged.
Testing
tscreports only the five existingSelectItemiderrors inworkspace.tsx.