Repository navigation
feat: migrate to vanilla RN app and upgrade to 0.87 - #1158
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The broad native-project replacement requires human validation, and the new iOS launch screen still displays an inconsistent temporary app name.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Migrates the example from React Native Test App to standalone React Native 0.87.1 Android and iOS projects, while updating library tooling and codegen APIs.
Changes:
- Adds vanilla Android and iOS example projects and removes visionOS support.
- Upgrades React Native, React, TypeScript, navigation, and testing dependencies.
- Updates Metro, Babel, TypeScript, linting, native dependencies, and CI builds.
| File | Description |
|---|---|
tsconfig.json |
Updates TypeScript and module resolution settings. |
src/PagerViewNativeComponent.ts |
Uses public React Native codegen exports. |
package.json |
Upgrades tooling and Jest configuration. |
example/visionos/Podfile.lock |
Removes the visionOS lockfile. |
example/visionos/Podfile |
Removes visionOS CocoaPods configuration. |
example/src/component/NavigationPanel/types.ts |
Replaces an alias with a relative import. |
example/react-native.config.js |
Configures local library autolinking. |
example/package.json |
Upgrades and simplifies example dependencies. |
example/metro.config.js |
Adds monorepo-aware Metro configuration. |
example/ios/PrivacyInfo.xcprivacy |
Removes the obsolete privacy manifest location. |
example/ios/Podfile.lock |
Locks React Native 0.87 iOS dependencies. |
example/ios/Podfile |
Adds vanilla React Native CocoaPods setup. |
example/ios/PagerViewExample/PrivacyInfo.xcprivacy |
Normalizes the app privacy manifest. |
example/ios/PagerViewExample/LaunchScreen.storyboard |
Adds the iOS launch screen. |
example/ios/PagerViewExample/Info.plist |
Adds iOS application metadata. |
example/ios/PagerViewExample/AppDelegate.swift |
Adds the React Native iOS entry point. |
example/ios/PagerViewExample.xcworkspace/contents.xcworkspacedata |
References the standalone Xcode project. |
example/ios/PagerViewExample.xcodeproj/xcshareddata/xcschemes/PagerViewExample.xcscheme |
Adds the shared Xcode scheme. |
example/ios/PagerViewExample.xcodeproj/project.pbxproj |
Defines the native iOS application project. |
example/index.js |
Registers the example component directly. |
example/Gemfile.lock |
Updates locked Ruby tooling. |
example/Gemfile |
Adds Ruby standard-library dependencies. |
example/babel.config.js |
Switches to the Worklets Babel plugin. |
example/app.json |
Removes React Native Test App configuration. |
example/android/settings.gradle |
Adds vanilla React Native Gradle settings. |
example/android/gradlew.bat |
Updates the Windows Gradle wrapper script. |
example/android/gradlew |
Updates the Unix Gradle wrapper script. |
example/android/gradle/wrapper/gradle-wrapper.properties |
Upgrades Gradle. |
example/android/gradle.properties |
Updates React Native Android build properties. |
example/android/build.gradle |
Adds the standalone Android root build. |
example/android/app/src/main/res/values/styles.xml |
Adds the Android application theme. |
example/android/app/src/main/res/values/strings.xml |
Adds the Android application name. |
example/android/app/src/main/res/drawable/rn_edit_text_material.xml |
Adds React Native edit-text styling. |
example/android/app/src/main/java/com/pagerviewexample/MainApplication.kt |
Updates React Native application initialization. |
example/android/app/src/main/java/com/pagerviewexample/MainActivity.kt |
Cleans up the Android activity. |
example/android/app/src/main/AndroidManifest.xml |
Adds the Android application manifest. |
example/android/app/proguard-rules.pro |
Adds application ProGuard rules. |
example/android/app/debug.keystore |
Adds example debug signing credentials. |
example/android/app/build.gradle |
Defines the Android application build. |
example/.gitignore |
Removes obsolete bundle-output exclusions. |
example/.bundle/config |
Configures local Ruby dependencies. |
.prettierrc.js |
Removes the redundant Prettier configuration. |
.github/workflows/ios.yml |
Relies on the native iOS build for bundling. |
.github/workflows/android.yml |
Relies on the native Android build for bundling. |
.flowconfig |
Removes obsolete Flow configuration. |
.eslintrc.js |
Updates ignored paths and globals. |
Files not reviewed (1)
- example/ios/PagerViewExample.xcworkspace/contents.xcworkspacedata: Generated file
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Release scripts cannot resolve the example CLI, and the published typings silently drop React Native 0.79 compatibility.
Review effort: Balanced
Findings: 1
Resolved since last review (1)
Files not reviewed (1)
- example/ios/PagerViewExample.xcworkspace/contents.xcworkspacedata: Generated file
Previously missed (1)
In code that hasn't changed since last review
src/PagerViewNativeComponent.ts:4
This changes the published declaration to depend on top-level CodegenTypes and codegen helper exports, but React Native 0.79 (the previous development baseline) does not expose those in its top-level typings while this package still declares react-native: "*". TypeScript consumers on 0.79 will therefore fail to resolve the generated declarations. Either retain compatible declaration imports or raise and document the minimum React Native peer version as a breaking compatibility change.
Comment on lines
+35
to
+36
| "example:android:release": "cd example; react-native run-android --mode \"Release\" --appId com.pagerviewexample --active-arch-only", | ||
| "example:ios:release": "cd example; react-native run-ios --mode \"Release\"", |
krozniata
force-pushed
the
feat/rn-87-vanilla
branch
from
October 7, 2026 10:38
3fc5959 to
cd78955
Compare
krozniata
added this pull request to stack #1160
October 7, 2026 10:39
krozniata
force-pushed
the
feat/rn-87-vanilla
branch
from
October 7, 2026 10:52
cd78955 to
6c0cee5
Compare
🟢 e2e: 11 passedAll 11 tests in 9 files
e2e 0.18.0 · 3m 14s · android · run artifacts |
🟢 e2e: 13 passedAll 13 tests in 11 files
e2e 0.18.0 · 5m 36s · ios · run artifacts |
troZee
reviewed
Oct 7, 2026
| path: example/ios/Pods | ||
| key: ${{ hashFiles('example/ios/Podfile.lock') }} | ||
|
|
||
| - name: Bundle app |
troZee
reviewed
Oct 7, 2026
| @@ -0,0 +1,2 @@ | |||
| BUNDLE_PATH: "vendor/bundle" | |||
Collaborator
There was a problem hiding this comment.
could you check, if this file should be added?
troZee
reviewed
Oct 7, 2026
| @@ -1,44 +1,27 @@ | |||
| package com.pagerviewexample; | |||
troZee
reviewed
Oct 7, 2026
| <item android:state_pressed="false" android:state_focused="false" android:drawable="@drawable/abc_textfield_default_mtrl_alpha"/> | ||
| For more info, see https://bit.ly/3CdLStv (react-native/pull/29452) and https://bit.ly/3nxOMoR. |
Collaborator
There was a problem hiding this comment.
- https://bit.ly/3k8fX7I → https://chromium.googlesource.com/android_tools/+/7200281446186c7192cb02f54dc2b38e02d705e5/sdk/extras/android/support/v7/appcompat/res/drawable/abc_edit_text_material.xml
- https://bit.ly/3CdLStv → Fix - TextInput Drawable to avoid Null Pointer Exception RuntimeError #17530 react/react-native#29452 (comment)
- https://bit.ly/3nxOMoR → NullPointerException:tempt to invoke virtual method 'android.graphics.drawable.Drawable android.graphics.drawable.Drawable$ConstantState.newDrawable(android.content.res.Resources)' react/react-native#17530 (comment)
troZee
approved these changes
Oct 7, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
krozniata
force-pushed
the
feat/rn-87-vanilla
branch
from
October 8, 2026 06:35
8e98231 to
705cc2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates example to vanilla RN app and upgrades it to
v0.87.1Also fixes Typescript in example as it was missing
tsconfigTest Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md