Skip to content
This repository was archived by the owner on Jul 20, 2026. It is now read-only.

Revert "chore: installing pnpm instead of relying on cache" - #114

Merged
Kylejeong2 merged 1 commit into
mainfrom
revert-113-kyle/gro-275-add-changesets-better-publishing-to-mcp
Aug 26, 2025
Merged

Kylejeong2 merged 1 commit into
mainfrom
revert-113-kyle/gro-275-add-changesets-better-publishing-to-mcp

Conversation

@Kylejeong2

Copy link
Copy Markdown
Member

Reverts #113

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR reverts changes made to the GitHub Actions release workflow configuration in .github/workflows/release.yml. The revert undoes modifications to the order of pnpm and Node.js setup steps, moving pnpm setup back to after Node.js setup and re-enabling the pnpm cache in the setup-node action.

The original change (PR #113) had modified the workflow to install pnpm before setting up Node.js and disabled the pnpm cache to avoid circular dependency issues. However, that change apparently broke pnpm installation in releases, prompting this revert. The current configuration now has Node.js setup first with cache: 'pnpm' enabled, followed by pnpm installation using pnpm/action-setup@v4.

This workflow is part of the project's CI/CD pipeline and is responsible for handling package management and dependency installation during the release process. The workflow configuration is critical for ensuring that releases can be built and published successfully.

Confidence score: 2/5

  • This PR introduces a logical inconsistency where Node.js setup attempts to use pnpm cache before pnpm is actually installed
  • Score reflects the circular dependency issue created by trying to cache pnpm dependencies before pnpm installation
  • Pay close attention to .github/workflows/release.yml and monitor release workflow executions

1 file reviewed, 1 comment

Edit Code Review Bot Settings | Greptile

uses: actions/setup-node@v4
with:
node-version: 20
cache: 'pnpm'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Setting cache: 'pnpm' before pnpm is installed (line 25-28) creates a logical dependency issue. The cache setup may fail or be ignored since pnpm isn't available yet.

@Kylejeong2
Kylejeong2 merged commit 6b2b4d3 into main Aug 26, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants