Repository navigation
fix(tests): prevent background uploads from racing VCR replay - #953
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 16, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/fix-flaky-sdk-test-82fc511d
branch
October 16, 2026 00:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests could leave real background HTTP uploads running into later cassette-backed tests. In the failing Windows Python 3.14 job,
test_span_filters_backend_parityescaped VCR replay and received a live API 401 while unrelated uploads were still running.Make the memory logger fixture provide the same logger to worker threads, and use memory loggers in the span export and project-group tests that were starting real uploads. Tighten the
asyncio.to_threadtest to require both parent and worker spans; it fails before the fixture fix because only the parent is captured.Validation:
test_coresession on macOS with Python 3.14.8 and--vcr-record=none: 1,090 passed, 106 skipped, 12 xfailed.