Repository navigation
perf(openai): avoid redundant response serialization - #952
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoOct 16, 2026
Merged
Conversation
Pass raw stream chunks and response objects through to core logging, avoiding repeated conversion while preserving aggregation and tool span behavior.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4463302ebe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Read embeddings and moderation results from either mapping responses or SDK objects without dumping the full response.
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/trim-openai-serialization-c7e59f5c
branch
October 16, 2026 00:22
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core logging omits
bytes: Nonefrom streamed logprob entries because the entries now reachbt_safe_deep_copyas Pydantic objects and are dumped withexclude_none=True._choices_outputremains unchanged, preservingrefusal: Noneandtool_calls: Nonein non-streaming chat output.Validation
nox -s 'test_openai(latest)' -- --vcr-record=none(81 passed)No cassettes were re-recorded or changed.