Repository navigation
fix(google-genai): avoid redundant serialization and preserve stream parts - #951
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7270897aa3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fec2fd14f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Summary
response_formatclasses do not break traced calls.Logged shape
Streamed code execution parts now log under
executable_codeorcode_execution_resultin provider order. Previously, the pydanticPartattribute check caused these parts to be logged as{"function_call": null}, and aggregation could move code parts after all text.Validation
test_google_genai(latest)suite: 44 passed, 2 skipped, replay-only.Follow-up observation
_reconstruct_interaction_outputs_from_eventsstill materializes each event fragment before merging deltas. Media fragments may therefore create repeated attachment materialization; this optional optimization was left unchanged.