Skip to content

fix(openai-agents): preserve response metadata during tracing - #950

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/fix-response-tracing-034efa40
Oct 16, 2026
Merged

Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/fix-response-tracing-034efa40

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Member

Summary

  • Copy Response.metadata before adding response fields so tracing does not mutate the OpenAI Agents response object.
  • Exclude None values from response dumps added to span metadata.
  • Null response fields such as error, incomplete_details, max_output_tokens, previous_response_id, and user are omitted.

Validation

  • nox -s test_openai_agents -- --vcr-record=none (latest, 0.13.6, 0.0.19)
  • make fixup
  • Reused checked-in cassettes; no cassette re-recording.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T00:06:53.878205Z 0f43a46 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit c66cd86 into main Oct 16, 2026
98 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi/fix-response-tracing-034efa40 branch October 16, 2026 00:14
@AbhiPrasad

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant