Skip to content

fix(instructor): log only final partial snapshot - #948

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/log-final-partial-5f556a3f
Oct 16, 2026
Merged

Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/log-final-partial-5f556a3f

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Member

Summary

  • Log only the final snapshot for sync and async create_partial calls, avoiding retention and deep-copying every progressively larger snapshot.
  • Keep create_iterable output as a list of distinct items.
  • Add VCR-backed coverage and cassettes for Instructor 1.17.0 and 1.11.0.

Output shape change

create_partial spans now log the final partial model directly instead of a list of every yielded snapshot. This is an intentional change to the logged output shape.

Reviewer: please confirm this output shape change is intentional.

Validation

  • mise exec -- nox -s 'test_instructor(latest)' -- -k 'create_partial_logs_final_snapshot'
  • mise exec -- nox -s 'test_instructor(1.11.0)' -- -k 'create_partial_logs_final_snapshot'
  • Pre-commit hooks passed during commit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T23:52:56.403060Z 6100d24 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 184086f into main Oct 16, 2026
98 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi/log-final-partial-5f556a3f branch October 16, 2026 00:07
@AbhiPrasad

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant