Repository navigation
fix(pydantic-ai): preserve unshaped message fields - #947
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 16, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/simplify-pydantic-shaping-64ae3725
branch
October 16, 2026 00:13
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_shape_messages; core serialization now preserves nested dataclass parts.Logged shape
Known fields retain the same structure. Prompt-bearing messages without binary content can now include newer pydantic_ai fields that the previous allowlist dropped. The raw-versus-dumped comparison found matching keys and values; key order may differ.
Validation
nox -s 'test_pydantic_ai_integration(latest)' -- -k 'shape_message_and_response_pass_through_when_no_binary or conversation_messages_serialize_same_with_or_without_adapter_dump'— 2 passed.nox -s 'test_pydantic_ai_integration(latest)' -- -k 'test_agent_with_conversation' --vcr-record=none— 5 passed.