Repository navigation
feat(ci): make the root pre-push hook fast by default - #497
Merged
Merged
Conversation
A push now runs the secret scan, each changed app's bun run check, the UI tests for the files it changes, shared packages and the static Compose checks. Full suites, builds, budgets, semgrep, osv-scanner and the smoke run stay in the pull request's required checks. FULL_PREPUSH=1 git push runs the whole gate locally. The first product made the same change after paying the full gate on every push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root
pre-pushhook now runs a fast gate by default:bun run check(typecheck, lint, lint:meta, format, knip, as the app defines it)vitest --changedsince the branch's last push, or main for a new branch)Full test suites, builds, bundle budgets, semgrep, osv-scanner and the smoke and Playwright runs stay in the pull request's required checks, which block the merge.
FULL_PREPUSH=1 git pushruns the whole gate locally, unchanged.Tinkercaster, the first product on the template, made the same change after paying the full gate on every push. The full gate's Playwright run also failed whenever another stack held :7330/:7331, so pushes were routinely made with
--no-verify. Ledger entry 119 is updated.Docs: AGENTS.md, the public
agents.md,lint-as-contract,apps/ui/budgets.mdand the changelog now describe the fast and full gates.Test plan
--no-verify: 19stools/agent/pre-push-shell.test.ts: the fast path exits before the full gate and--secrets-onlystops after gitleaksagent:quality,apps/docsbuild:ci