Repository navigation
fix(security): resolve the open Dependabot and CodeQL alerts - #494
Merged
Merged
Conversation
4.7.10 is the only release that fixes two critical JavaScript-injection advisories. It is exempted from the 7-day quarantine, like form-data was, and the three osv ignores are removed.
The override already installed 0.35.5, but Dependabot reads the direct dependency and kept GHSA-wq5f-xc86-pv6w open.
The isolated runtime passed the Postgres and Valkey passwords as docker arguments. They now travel in the Docker client's environment through -e NAME, so they never reach a process list or an error message. Resolves CodeQL js/clear-text-logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes every open security alert on main.
minimumReleaseAgewindow, so it gets a documented per-package exemption inapps/api/bunfig.toml, the same wayform-datadid. The three osv ignores that hid these advisories are removed. Remove the exemption after 2026-10-12.apps/docsandapps/sitestill said 0.35.4, and Dependabot reads that.dockerarguments. They now go through the Docker client's environment (-e NAMEwith no value), andvalkey-cliauthenticates withREDISCLI_AUTH. No secret appears in argv,psor an error message.Test plan
scripts/ci/bun-audit.shclean for apiapps/api:bun run check,bun run test(1289 pass); email templates compile with 4.7.10apps/docsbuild:ci,apps/sitevalidate,agent:check(98 pass),agent:quality--entrypoint shand-e VALKEY_PASSWORDin a throwaway container:valkey-cliwithREDISCLI_AUTHgets PONG, and without it gets NOAUTH