Repository navigation
Preserve PostgreSQL node identities across role changes - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a switchover, moving a host from standby to primary in configuration previously changed its generated repmgr ID to 1. Reordering standbys could also change their identities.
Allow an explicit
node_idon each host and use it in repmgr templates, clone setup and registration checks. Reject invalid or duplicate IDs before deployment. Existing configurations retain their current defaults. Document how to preserve existing IDs when changing roles and prepare version 0.9.8.Validation: 366 tests and 1,097 assertions pass, RuboCop passes, the dependency audit reports no vulnerabilities, and the gem builds. The new tests cover role changes, reordered standbys, ID collisions and invalid values.