Repository navigation
Conversation
Stop flag parsing at a bare `--` terminator so values like `-pos` and `--pos` are collected into `_`, matching common CLI tools. Fixes bombshell-dev#12
🦋 Changeset detectedLatest commit: 11bddda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle the bare
--terminator so remaining argv tokens are collected as positionals even when they look like flags (e.g.-pos,--pos).This matches the usual CLI pattern (
grep -i -- -pos,printf, etc.) and addresses #12.Changes
parse(), when a token is exactly--, push every following token into_(viacoerce) and stop flag parsing.--terminator itself is not included in_.--after the terminator is treated as a normal positional.Intentionally does not implement #13 (options without delimiter such as
-m700).Test plan
pnpm test— 26 tests passed (including 5 new double-dash cases)Fixes #12