Conversation
Collaborator
Author
|
Will wait until 3.1.0 fully complete for all downstream etc, then merge this next week hopefully |
Contributor
|
ACK 356817c. Checked the Rust CI, local just recipes, Android build/bindgen scripts, Swift XCFramework scripts, and docs path. The dependency-resolving Cargo commands consistently use --locked, while cargo fmt is correctly left unchanged. This looks consistent with the goal of failing on lockfile drift instead of silently updating Cargo.lock, without changing the binding/runtime API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build and binding-generation commands could silently update the committed Cargo.lock when dependency resolution changed. Add --locked to CI, local recipes, and platform build, bindgen, and documentation scripts so they fail instead of modifying the lockfile.
Notes to the reviewers
Documentation
bdk_walletbitcoinuniffiChangelog
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingchangelog:*labelNew Features:
Bugfixes: