Repository navigation
feat: add PyInfo.direct_implicit_pyc_files and PyExecutableInfo.venv_runfiles - #4341
Merged
aignas merged 1 commit intoOct 27, 2026
Merged
Conversation
…runfiles PyInfo had direct counterparts for every pyc field except the implicit pyc files, and PyExecutableInfo had the venv's interpreter runfiles but not the application's. Tools that only see providers, like a packager's aspect, need both to tell a target's own files apart from what it inherits. Also pulls a few internals out so they can be reused without change in behavior: py_info_runfiles_files() for the files a binary takes from a dependency's PyInfo, get_runtime_files() for the runtime files, and get_package_and_version() taking the data files instead of the ctx. Split out of bazel-contrib#4254.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyInfohad a direct counterpart for every pyc field except the implicit pyc files, andPyExecutableInfoexposed the venv's interpreter runfiles but not the application's. Tools that only see providers, like a packager's aspect, need both to tell a target's own files apart from what it inherits.Also pulls a few internals out so they can be reused, with no change in behavior:
py_info_runfiles_files()for the files a binary takes from a dependency's PyInfo,get_runtime_files()for the runtime's files, andget_package_and_version()taking the data files instead of the ctx.Split out of #4254, which uses all of these.