Repository navigation
refactor(examples): replace compile_pip_requirements with uv lock rule - #4312
Merged
Merged
Conversation
`compile_pip_requirements` relies on `pip-compile`, whereas the `//python/uv:lock.bzl%lock` rule uses `uv` for faster and more modern lockfile generation. Replace `compile_pip_requirements` targets across the examples with `//python/uv:lock.bzl%lock`. Where examples previously generated a separate Windows lockfile via `requirements_windows`, define a second `lock` target passing `--python-platform=windows`.
rickeylev
marked this pull request as ready for review
October 22, 2026 16:22
dougthor42
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compile_pip_requirementsrelies onpip-compile, whereas the//python/uv:lock.bzl%lockrule usesuvfor faster and more modernlockfile generation.
Replace
compile_pip_requirementstargets across the examples with//python/uv:lock.bzl%lock. Where examples previously generated aseparate Windows lockfile via
requirements_windows, define a secondlocktarget passing--python-platform=windows.