Repository navigation
feat(rules): describe runfiles groups for rules_runfiles_group #4254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FrankPortman
wants to merge
13
commits into
bazel-contrib:main
Choose a base branch
from
FrankPortman:runfiles_group_describers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,212
−5
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fff00cd
feat(rules): describe runfiles groups for rules_runfiles_group
FrankPortman 546a1d2
feat(rules): move runfiles groups to the toolchain-walking describer API
FrankPortman cbc1133
DO NOT MERGE: use the rules_runfiles_group dev registry in nested wor…
FrankPortman 6024e17
chore: bump rules_runfiles_group to 99.0.0-dev.20261019.1.1cee2dd
FrankPortman b9818f9
fix(rules): load only the describer side of rules_runfiles_group
FrankPortman 5a7dc55
style: sort the runfiles group attributes, name the Bazel versions fo…
FrankPortman 7c3bb0a
docs: document the runfiles group describers
FrankPortman 66c84be
fix(rules): put namespace package venv links in their distribution's …
FrankPortman 35c4cc5
test: show configuring a binary's runfiles groups through aspect_hints
FrankPortman b585663
build: fetch rules_runfiles_group from its dev registry in WORKSPACE
FrankPortman 7a4c7a3
fix(rules): keep a wheel's console scripts in its distribution's group
FrankPortman 654e903
DO NOT MERGE: use the rules_runfiles_group dev registry in prebuilt_t…
FrankPortman 1b40985
test: show bucketing distributions together through aspect_hints
FrankPortman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # https://docs.bazel.build/versions/main/best-practices.html#using-the-bazelrc-file | ||
| try-import %workspace%/user.bazelrc | ||
| common --incompatible_python_disallow_native_rules | ||
|
|
||
| # TODO: Delete before merging; see the root .bazelrc. | ||
| common --registry=https://bazel-contrib.github.io/rules_runfiles_group --registry=https://bcr.bazel.build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| (rules) `py_binary` and `py_test` describe their runfiles groups for | ||
| [rules_runfiles_group](https://github.com/bazel-contrib/rules_runfiles_group), | ||
| so packaging rules like rules_img's `image_from_binary` can put the runtime, | ||
| each PyPI package and each library in a layer of its own. Needs Bazel 8.8 or | ||
| later ([#3757](https://github.com/bazel-contrib/rules_python/issues/3757)). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is ideal, but it can be a good default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's meant as the default. there's now a test showing how to change it per binary through aspect_hints. central config is the open question, I put the options in a top level comment.