Repository navigation
ci: add advisory AI docs PR reviewer with shadow-mode risk label - #2152
Merged
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
soheimam
marked this pull request as ready for review
October 19, 2026 17:49
Two-stage workflow (pull_request trigger on ubuntu-latest, workflow_run review on BaseRunnerGroup) that posts an advisory review comment and one risk: label on docs PRs from base-devrel and base-eng members. Security review: SPA-35356 (approved).
Addresses CodeQL js/incomplete-multi-character-sanitization and js/bad-tag-filter: fragments can no longer recombine into <!--, and the --!> end form is removed.
A page added together with its navigation entry was reported as not in navigation, because facts came from the default-branch docs.json. Facts now use the PR copy when docs.json changes (falling back to the default branch if it does not parse), links to pages added in the same PR resolve, and links to pages the PR removes are reported.
soheimam
force-pushed
the
soheimacanton/devrel-828-docs-pr-reviewer
branch
from
October 19, 2026 17:53
9ef55d9 to
1ac2495
Compare
ericbrown99
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adds an advisory AI reviewer for docs PRs from
base-devrelandbase-engmembers.risk: low|medium|high|criticallabel using fixed rules from the review ladder proposal. No AI is involved in the label. Shadow mode: nothing is enforced.Two workflows:
docs-pr-review-trigger.ymlruns onpull_requestonubuntu-latestwith no secrets and no permissions. It only starts stage 2.docs-pr-review.ymlruns onworkflow_runfrom the default branch on BaseRunnerGroup. It rejects forks, re-checks the PR through the API, checks team membership, and then makes one LLM Gateway call through the existingscripts/sync-from-base-stdclient.Notes to reviewers
base-std-docs-sync.yml..github/workflows/, so the CI Configuration gate needs 3 writer approvals.master, becauseworkflow_runonly runs from the default branch.Before merge:
DOCS_PR_REVIEW_MEMBERS_TOKENsecret (org Members: read only)skip-ai-reviewlabel and the fourrisk: low,risk: medium,risk: high,risk: criticallabelsTurn off for everyone with the repository variable
DISABLE_DOCS_PR_REVIEW=true, or for one PR with theskip-ai-reviewlabel.How has it been tested?
master(node --test scripts/docs-pr-review/__tests__/*.test.mjs).docs/docs.json, page placement and link checks use the PR's copy, so a page added together with its menu entry is not reported as orphaned. A test covers this.Source and security doc: cb-pages/devrel-ai-cc PR #29.
Screenshots
N/A (no user-facing changes)
Generated with Toshi