Repository navigation
docs(specs): explain how eip-8430 relates to eip-8130 #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
ec9c7bd
c6b7453
3a61585
4230647
91189fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -19,11 +19,20 @@ | |||||||||
| Base Transactions activate with the [Everest network upgrade](/upgrades/overview). Activation dates are TBD. | ||||||||||
| </Warning> | ||||||||||
|
|
||||||||||
| ## Relationship to EIP-8130 | ||||||||||
|
|
||||||||||
| EIP-8430 is not a rename of [EIP-8130](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-8130.md). It is a separate proposal that splits the transaction type out of EIP-8130, with no dependency on a keystore. | ||||||||||
|
|
||||||||||
| - **EIP-8430** defines the transaction type (`0x79`) described on this page. | ||||||||||
| - **EIP-8130** now specifies Keystore Accounts, an onchain keystore that authorizes account actors through authenticator contracts. It also describes how the Keystore can integrate with the EIP-8430 transaction type. | ||||||||||
|
|
||||||||||
| Earlier drafts of EIP-8130 defined the `0x79` transaction type themselves, so older material may call these "EIP-8130 transactions." EIP-8430 is an open proposal in the Ethereum EIPs repository, and EIP-8130 has Draft status. A proposal's EIP status does not tell you whether Base Transactions are live on Base. Activation follows the Everest network upgrade. | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Split the overloaded closing paragraph The paragraph covers legacy naming, EIP status, and activation in one block, and ends with an extra activation sentence that repeats the Warning above. Split it into two ideas and drop the duplicate activation line. Keep one sentence per idea, in active voice.
Suggested change
|
||||||||||
|
|
||||||||||
| ## Transaction Format | ||||||||||
|
|
||||||||||
| A Base Transaction uses transaction type `0x79`: | ||||||||||
|
|
||||||||||
| ```text Encoding lines expandable | ||||||||||
|
Check warning on line 35 in docs/specifications/base-transactions.mdx
|
||||||||||
| 0x79 || rlp([ | ||||||||||
| chain_id, | ||||||||||
| sender, // empty = recover from sender_auth | 20-byte address | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tighten the EIP-8130 bullet and define terms
The bullet is long and introduces "authenticator contracts" and "Keystore" without defining them. It also capitalizes "Keystore" inconsistently with "keystore" in line 24. Shorten it and use one form of the term.