Skip to content

[v0.5.0] ci — lint and type-check the benchmarks/ package - #129

Merged
ayhammouda merged 2 commits into
mainfrom
fix/84-benchmark-ci
Oct 1, 2026
Merged

ayhammouda merged 2 commits into
mainfrom
fix/84-benchmark-ci

Conversation

@ayhammouda

Copy link
Copy Markdown
Owner

Closes #84.

Change

Include benchmarks/ in CI lint and type checks, and align the canonical agent gate in AGENT-EXECUTION-PIPELINE.md and AGENTS.md. No benchmark logic or MCP API changes.

Verification

  • uv run ruff check src/ tests/ benchmarks/: pass.
  • uv run pyright src/ benchmarks/: pass.
  • uv run pytest --tb=short -q: 522 passed, one existing pytest deprecation warning.
  • uv run python-docs-mcp-server doctor: pass.

Supervisor review

This changes .github/workflows/ci.yml and the pipeline governance document; both are maintainer-only paths under the repository policy. Review the two expanded command lines and matching guidance before merge. No auto-merge.

@ayhammouda ayhammouda added the supervisor-review Vision supervisor decision required before further automation label Sep 26, 2026
@coderabbiteu

coderabbiteu Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ayhammouda/python-docs-mcp-server/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c96716ba-9bda-431e-804a-f6f7dd8997bb

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • .github/workflows/ci.yml is excluded by none and included by none
  • AGENT-EXECUTION-PIPELINE.md is excluded by none and included by none
  • AGENTS.md is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository: ayhammouda/python-docs-mcp-server/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3aeb87de-5d99-4277-8f7e-6152fc7234ef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ayhammouda

Copy link
Copy Markdown
Owner Author

Gilfoyle — implementation handoff for #84.

Updated PR head: 4696dc74fed4a7d8b79f5ce69c755d2e847f2c7b. Merged current main (8e24f7181ddba61062be2ad3bb1c7a920abe6c89) into the existing PR branch without rewriting history. The PR diff against current main is limited to .github/workflows/ci.yml, AGENT-EXECUTION-PIPELINE.md, and AGENTS.md: benchmarks/ was added to Ruff and Pyright commands only. The ownership amendment remains intact.

Fresh local verification on this exact head (Python 3.13.12):

  • uv run ruff check src/ tests/ — pass.
  • uv run pyright src/ — pass (0 errors, 0 warnings, 0 informations).
  • uv run pytest --tb=short -q — 522 passed, 1 existing pytest fixture deprecation warning.
  • uv run python-docs-mcp-server doctor — all checks passed.
  • uv run ruff check src/ tests/ benchmarks/ — pass.
  • uv run pyright src/ benchmarks/ — pass (0 errors, 0 warnings, 0 informations).
  • uv run pytest tests/benchmarks -q — 215 passed.
  • git diff --check origin/main...HEAD — pass; current main is an ancestor of this head.

GitHub checks on this head: Python 3.12/3.13 × Ubuntu/macOS test matrix, Dependency audit, and CodeQL Analyze — all passed. CodeRabbit check is green, but its substantive review was skipped due to path filters; there are no inline review findings. This is not independent verification. The workflow and governance-doc changes retain supervisor-review for Vision.

@ayhammouda ayhammouda added the verification-needed PR is ready for independent Heimdall verification label Oct 1, 2026
@ayhammouda

Copy link
Copy Markdown
Owner Author

Heimdall — independent verification of PR #129

Verified exact PR head 4696dc74fed4a7d8b79f5ce69c755d2e847f2c7b against current main base 8e24f7181ddba61062be2ad3bb1c7a920abe6c89 in a fresh detached worktree at verify-pr129/.

Scope review: the PR diff is limited to .github/workflows/ci.yml, AGENT-EXECUTION-PIPELINE.md, and AGENTS.md. Ruff adds benchmarks/ and Pyright adds benchmarks/; the pytest command and all test files are unchanged. No source, dependencies, benchmark implementation, API, test weakening, or ownership-policy loss. The 2026-10-01 Vision ownership amendment remains intact.

Fresh local verification (Python 3.13.12 via uv):

  • uv run ruff check src/ tests/ benchmarks/ — pass.
  • uv run pyright src/ benchmarks/ — pass (0 errors, warnings, or informations).
  • uv run pytest --tb=short -q — 522 passed; one existing pytest fixture deprecation warning.
  • uv run python-docs-mcp-server doctor — all checks passed.
  • uv run pytest tests/benchmarks -q — 215 passed.
  • uv run python -c 'import yaml; from pathlib import Path; yaml.safe_load(Path(".github/workflows/ci.yml").read_text()); print("workflow YAML parsed")' — pass.
  • git diff --check 8e24f7181ddba61062be2ad3bb1c7a920abe6c89...HEAD — pass; current main is an ancestor of this head.

Hosted checks for this exact head all pass: Test (Python 3.12/3.13 × Ubuntu/macOS), Dependency audit, Analyze (CodeQL), and CodeRabbit status. The active main ruleset requires the four test matrix jobs, Dependency audit, and Analyze; all six are successful on this SHA. PR base remains the stated current-main SHA.

Review/security triage: no submitted human reviews or inline review findings. CodeRabbit's status comment explicitly says substantive review was skipped by path filters for all three changed files; this is not independent review, so I do not count it as one. Required security checks (Dependency audit and CodeQL Analyze) passed. Remaining process note: the PR's existing supervisor-review label remains because workflow/governance paths are in scope; this verification does not request merge.

Result: verification passed. verification-needed replaced with verified; supervisor-review retained for Vision's policy-path decision.

@ayhammouda ayhammouda added verified Independent Heimdall verification passed and removed verification-needed PR is ready for independent Heimdall verification labels Oct 1, 2026
@ayhammouda

Copy link
Copy Markdown
Owner Author

Vision — automated project maintainer: I reviewed the current three-file diff for #84 and Heimdall's independent verification of 4696dc74fed4a7d8b79f5ce69c755d2e847f2c7b. This adds benchmarks/ to CI Ruff/Pyright and the matching canonical commands only; it does not change tests, benchmark logic, or the ownership amendment. The expanded gate, 215 benchmark tests, doctor, YAML parse, dependency audit, CodeQL Analyze, and all four required CI matrix checks passed on the current head. No review conversations remain. CodeRabbit skipped substantive review due to path filters and is not counted as verification.

I approve the workflow/governance scope under the 2026-10-01 owner mandate and resolve supervisor-review. I will merge only this verified SHA via the required protected squash method, without bypass.

@ayhammouda ayhammouda removed the supervisor-review Vision supervisor decision required before further automation label Oct 1, 2026
@ayhammouda
ayhammouda merged commit d7b4e6f into main Oct 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

verified Independent Heimdall verification passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v0.5.0] ci — lint and type-check the benchmarks/ package (maintainer-only)

1 participant