Repository navigation
Conversation
This was referenced Oct 19, 2026
Open
gouveags
marked this pull request as ready for review
October 19, 2026 00:23
gouveags
marked this pull request as draft
October 26, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #110.
Scope
Prepare Bedrock Runtime client tests and usage guidance for the standard request-compression settings inherited from Smithy Python:
disable_request_compressionandrequest_min_compression_size_bytes(default 10240; inclusive range 0 through 10485760).This draft changes only the README, compression regression tests and a feature changelog entry. All generated source matches the PR base. The compact-schema/model migration is excluded and left to the normal SDK regeneration process.
Tests cover defaults, threshold endpoints, environment configuration and client-setting precedence. They also check that
Converse,ConverseStream,InvokeModelandInvokeModelWithResponseStreamremain uncompressed at both default and zero thresholds when the service model does not advertise compression.Prerequisites
This PR is not ready to merge. It requires:
No compatibility shim, copied compression engine, dependency bump or manual service metadata is introduced here. Current declared dependencies do not provide these compression controls; the README marks the example as pending upstream support.
Bedrock Runtime additionally needs service acceptance and upstream compression metadata before requests can actually be compressed. Mantle's provider-compatible APIs require separate service/client integration. Compression can reduce upload bytes; this PR establishes neither endpoint acceptance nor a latency improvement.
Validation
Revision:
d9ad0b2e9a820eeda5b37a574443d5dd0690b3b1.8f209d245501792c7b18ce197c194170ca4d6564.git diff --checkpassed.1ae921bac24a6ecebc61b8b43cd36382d359b4ec.APIOperation(schema=...), while the newer runtime requiresstatic_schema=.... This is the expected unresolved regeneration prerequisite, not a passing final-checkout test result.Re-run from
clients/aws-sdk-bedrock-runtimeonce compatible runtime dependencies and normally regenerated client source are available:Related contribution: botocore threshold-range fix, independent of this draft.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.