Skip to content

test(otel): cover replay and callback delivery - #796

Open
zhongkechen wants to merge 1 commit into
fix/python-testing-replay-state-20261021from
test/python-otel-conformance-20261021
Open

zhongkechen wants to merge 1 commit into
fix/python-testing-replay-state-20261021from
test/python-otel-conformance-20261021

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Add OpenTelemetry conformance coverage for replay and callback delivery through the public SDK APIs.

Coverage

  • Case 21: completed steps reuse saved results during replay.
  • Cases 22–23: user-function and callback code retain the expected tracing context.
  • Case 24: invocation retry status is represented correctly.
  • Case 25: caught callback failures without error details retain the expected result, status and replay behavior.
  • Case 26: an externally completed callback reaches the exporter before the observed step runs. Its raw terminal export count remains one across both later replay barriers and final completion. Parent/trace identity and span timestamps are checked separately.

The change includes handlers, SAM/Makefile mappings, local integration tests, documentation and immutable workflow/catalog pins. Handlers use the Core 3 / OTel 2 factory API.

Stack

main → #758 → #795 → #796

#758 provides the Core/OTel runtime fixes. #795 aligns the local testing service's replay visibility and update acknowledgment with the service. This PR adds the conformance coverage that depends on those layers.

Validation

All 112 local conformance-package/workflow checks pass, along with package lint, formatting and commit-message checks. Unit observers accept repeated natural End observations and verify detached error copies; exported-span and error-payload assertions remain strict. Conformance handlers and requirements are unchanged by those observer adjustments. Delaying the case-26 callback's first rendering until invocation 3 or 4 is rejected by the live exporter assertion; recorded timestamps alone no longer let those regressions pass.

Shared conformance #131, including the strengthened chained-invoke parent/ancestry qualification, remains a merge prerequisite. Local results do not replace that qualification.

@github-actions

This comment has been minimized.

@zhongkechen zhongkechen mentioned this pull request Oct 21, 2026
7 of 11 tasks
@zhongkechen
zhongkechen added this pull request to stack #800 October 21, 2026 19:32
@zhongkechen
zhongkechen removed this pull request from stack #800 October 22, 2026 17:25
@zhongkechen
zhongkechen added this pull request to stack #809 October 22, 2026 17:25
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 17:28 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 19:38 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 20:15 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 20:48 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 21:03 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 22:35 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen force-pushed the test/python-otel-conformance-20261021 branch from fb98f02 to 812e8bb Compare October 22, 2026 23:25
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 23:26 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen force-pushed the test/python-otel-conformance-20261021 branch from 812e8bb to 14e6d62 Compare October 23, 2026 00:04
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 23, 2026 00:05 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. The prior callback export-phase gap is addressed. Review was static: tests were not run, and external workflow/catalog compatibility was not verified.

Reviewed commit 14e6d62d0135dcbfbad354c6781d0ad17fa14d45. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 14e6d62d Deployed Oct 23, 2026 by zhongkechen via ai-pr-review / Codex review / Generate Codex review #2165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant