Repository navigation
test(batch): add Lambda Managed Instances isolation coverage - #5768
Merged
Merged
Conversation
svozza
reviewed
Oct 2, 2026
Contributor
|
Thanks for this! Can you reply to the issue this PR closes so I can assign it to you? |
1 of 2 tasks
Contributor
Author
|
Thanks! I've commented on #5684 so you can assign it to me. |
svozza
reviewed
Oct 3, 2026
svozza
reviewed
Oct 5, 2026
svozza
approved these changes
Oct 5, 2026
Contributor
|
Thank you for your work here, great to have LMI test coverage of this utility. Merged! |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Contributor
Author
|
Thanks, @svozza! I appreciate the careful reviews and the help getting the tests into shape. Glad to have the Batch LMI coverage merged, and happy to make my first contribution here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add real-platform Batch isolation coverage for Lambda Managed Instances. The suite exercises module-scoped standard SQS and asynchronous FIFO processors with overlapping invocations, checking that record handlers, partial failures, and failed FIFO groups remain scoped to their invocation.
Changes
test:e2e:lmi, keep ordinary E2E runs separate, and increase shared capacity to retain spare instance headroom for the expanded matrix. The two Batch variants deploy and tear down sequentially.Validation
npx vitest --run --maxWorkers=4 --testTimeout=30000 --exclude tests/unit/layer-publisher.test.ts --coverage --coverage.thresholds.100 tests/unit. The existing CDK stack-tagging test exceeds its default five-second timeout on this Windows machine; the longer timeout is a local command-line setting only.Issue number: closes #5684
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.