Repository navigation
K2GO-449 refactor(app): migrate ZimDownloadService onto ContentDownloadServiceBase - #653
Merged
Merged
Conversation
…adServiceBase Thin ZimDownloadService to the shared base, keeping the ZIM hooks: session, actions, notification title, START item from files/labels/bytes (byte-weighted percent), wishlist cleanup on cancel and done, and the ADR-390 catalog self-heal via onItemError. No base change: the base already provides the label-threaded notification, the returnIntent() hook, and onCancel() from the Books slice.
…ctor/K2GO-449-zim-on-base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate ZimDownloadService onto the shared ContentDownloadServiceBase (K2GO-449, slice 2).
Why
ZIM still carried its own foreground-service shell. Thinning it onto the base removes the duplicated
onStartCommand / notification / channel / Host plumbing, so ZIM now takes the same path as Books,
CodeAssets and Addons.
Scope
files/labels/bytes with byte-weighted percent, wishlist cleanup on cancel/done, and the ADR-390
catalog self-heal via onItemError). Net -53 lines. The static UI API is unchanged.
returnIntent() hook and onCancel() from the Books slice.
Verification
Build + lint green; double code-review (two passes); device-tested on a Samsung A16 (3 ZIMs, 118 MB:
byte-weighted progress + speed, notification with tap-to-return, download completes).