Repository navigation
fix: ignore a UTF-8 byte order mark in robots.txt - #2351
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RobotsTxtFile.loaddecodes the response body withutf-8, which keeps a leading UTF-8 byte order mark (BOM) as\ufeff. Protego then does not recognize the first line (\ufeffUser-agent: *) as aUser-agentdirective, so the rules of the first group are ignored andis_allowedreturnsTruefor disallowed paths. Withrespect_robots_txt_file=True, the crawler fetches pages the site disallows.utf-8-sig, which drops the BOM if present and is otherwise identical toutf-8.Issues
Testing
test_load_robots_txt_with_utf8_bomintests/unit/_utils/test_robots.py. It fails onmaster(assert not robots.is_allowed(...)getsTrue) and passes with the fix, for all HTTP client parametrizations.uv run pytest tests/unit/_utils/test_robots.py: 20 passed.ruff check,ruff format --check, andty checkpass on the changed files.Checklist