Repository navigation
refactor(http-clients)!: Replace crawl() and stream() with send_request - #2349
Merged
Merged
Conversation
github-actions
Bot
added
the
t-tooling
Mantisus
changed the title
HttpClientHttpClient
Mantisus
force-pushed
the
refactor-http-client
branch
2 times, most recently
from
October 24, 2026 16:22
cb8b05a to
c20c567
Compare
Mantisus
marked this pull request as ready for review
October 24, 2026 16:22
Mantisus
requested review from
Pijukatel and
vdusek
and removed request for
vdusek
October 24, 2026 16:22
Mantisus
changed the title
HttpClientHttpClient base class
Mantisus
force-pushed
the
refactor-http-client
branch
from
October 25, 2026 16:45
c20c567 to
887e251
Compare
vdusek
changed the title
HttpClient base classHttpClient base class and drop crawl()
vdusek
approved these changes
Oct 28, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Just a few minor comments, otherwise LGTM
Mantisus
force-pushed
the
refactor-http-client
branch
2 times, most recently
from
October 29, 2026 14:39
8d72acd to
38558a1
Compare
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Mantisus
force-pushed
the
refactor-http-client
branch
from
October 29, 2026 23:55
38558a1 to
1d85347
Compare
vdusek
changed the title
HttpClient base class and drop crawl()HttpClient to send_request and move redirects and cookies to the base class
vdusek
changed the title
HttpClient to send_request and move redirects and cookies to the base classcrawl() and stream() with send_request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HttpClientnow has a single public method,send_request, which returns the response before its body is read. A client implements only_fetch, which sends one request. The base class follows redirects, sends and stores the session cookies on every hop, and drops credentials when a redirect leaves the origin, the same way for every client.crawl()andstream()are removed.The
timeoutofsend_requestcovers the redirect chain and reading the body, every client takesfollow_redirects, andHttpResponseis an abstract base class that closes the response when used as an async context manager. The v2 upgrade guide describes what changes for existing code and custom clients.Issues
HttpClientbase class #2307