Repository navigation
feat(autoscaling)!: Add ConcurrencySystem to share one concurrency budget between crawlers - #2322
Merged
Merged
Conversation
github-actions
Bot
added
the
t-tooling
Mantisus
force-pushed
the
split-autoscaled-pool
branch
2 times, most recently
from
October 14, 2026 18:54
a738bbb to
97286df
Compare
Mantisus
marked this pull request as ready for review
October 14, 2026 19:48
Mantisus
changed the title
ConcurrencySystem to share one concurrency budget between crawlersConcurrencySystem to share one concurrency budget between crawlers
vdusek
force-pushed
the
split-autoscaled-pool
branch
2 times, most recently
from
October 16, 2026 07:59
028fd2c to
b6e4fad
Compare
Pijukatel
reviewed
Oct 16, 2026
vdusek
reviewed
Oct 16, 2026
Mantisus
force-pushed
the
split-autoscaled-pool
branch
2 times, most recently
from
October 18, 2026 16:57
39a2094 to
9294fec
Compare
vdusek
self-requested a review
October 19, 2026 11:19
Pijukatel
approved these changes
Oct 19, 2026
vdusek
reviewed
Oct 21, 2026
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Mantisus
force-pushed
the
split-autoscaled-pool
branch
from
October 21, 2026 17:16
4dc85f7 to
31e6c82
Compare
This was
linked to
issues
Oct 21, 2026
This was referenced Oct 21, 2026
vdusek
pushed a commit
that referenced
this pull request
Oct 28, 2026
…stop()` to the current run (#2332) ### Description `AutoscaledPool` now calls `is_finished_function` only when none of its own tasks are running and it can't start a new one, either because no task is ready or because a shared concurrency system has no free capacity. Before, it was called on every loop iteration, even with tasks in flight. - Crawlers no longer query the request manager's `is_finished()` every half second during a crawl, so storage backends get fewer calls. - A pool whose `is_task_ready_function` always resolves to `True` no longer finishes. It has to resolve to `False` once the work runs out. The upgrade guide covers this. - A paused pool doesn't finish until it's resumed. - `crawler.stop()` now applies only to the current run. A crawler that was stopped once used to end every later `run()` immediately. - After `stop()` or reaching `max_requests_per_crawl`, the crawler logs once that it takes no new requests and again when the remaining requests have finished. The stop reason no longer ends with a double period. ### Issues - Follow-up: #2322
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Load monitoring and concurrency scaling move from
AutoscaledPoolinto a newConcurrencySystem. Pass one system to several crawlers through the newconcurrency_systemoption to cap their combined concurrency. The autoscaling classes are now public incrawlee.autoscaling.Autoscaling logs move to DEBUG, and
max_tasks_per_minutenow counts the tasks started over the last 60 seconds. Breaking changes are in the v2 upgrade guide.Issues
✍️ Drafted by Claude Code