fix(autoscaling): Keep min_concurrency tasks running while the system is overloaded - #2235
Merged
Merged
Conversation
vdusek
approved these changes
Sep 16, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM... But @Pijukatel could you take a look as well? I don't think this could cause any harm, but touching the autoscaled pool always makes me nervous 😄
Pijukatel
approved these changes
Sep 16, 2026
Pijukatel
left a comment
Pijukatel
left a comment
Collaborator
There was a problem hiding this comment.
It seems reasonable to me, but this would be worth syncing with the JS version of the tooling - especially with the upcoming v4 release.
Collaborator
|
Issue: apify/crawlee#4129, but it seems a JS version already behaves this way. |
Collaborator
Author
Yes, I checked the behavior in TS before making the fix. |
vdusek
added a commit
to Kuang-xianxin/crawlee-python
that referenced
this pull request
Sep 16, 2026
Resolved a conflict in the `AutoscaledPool` class docstring, where apify#2235 rewrote the concurrency sentence while this branch extended the error sentence. The merged text keeps both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
min_concurrencytasks running while the system is overloaded instead of dropping to zero concurrency. It fixesAutoscaledPoolfreezing after an overload.Testing
test_keeps_min_concurrency_when_overloaded