Repository navigation
Conversation
…va class to not being exclusive for read instructions
…multiplication chain into their own statement block
…parate method for processing the children of matrix multiplication hops chore(test/functions/rewrite/RewriteSplitDagUnkownNnzReadTest.java): update assert string check to the new version of the log output
… into separate statement block only before the chain instead of before and after the chain
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
- Coverage 76.68% 76.67% -0.02%
==========================================
Files 452 452
Lines 28066 28066
==========================================
- Hits 21523 21520 -3
- Misses 6543 6546 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…nd AFTER the MM chain regardless of whether input nnz are known or not NOTE: Thereby, we create a separate statement block for every mm chain, in which we can optimize and rewrite the mm chain isolated from other operations.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
this PR splits the inputs of a matrix multiplication chain into their own statement block to ensure the MM chain receives correct sparsity information as input (i.e., the sparsity is computed before sparsity rewrites).
The tests are modified accordingly.
All the best,
David