Repository navigation
WW-5760 Upgrade OGNL to version 3.4.15 - #1993
Merged
Merged
Conversation
OGNL 3.4.15 (orphan-oss/ognl#660) no longer reports a property as settable when its only backing member is a static or final field, so CompoundRootAccessor does not offer the parameter to an object that cannot take it. The new test pins that for a ModelDriven action. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lukaszlenart
marked this pull request as ready for review
October 6, 2026 13:22
|
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WW-5760
Upgrades OGNL from 3.4.14 to 3.4.15.
OGNL 3.4.15 includes orphan-oss/ognl#660, the 3.4.x backport of #658.
OgnlRuntime.hasSetPropertyno longer reports a property as settable when its only backing member is a static or final field, whichsetFieldValuerefuses to write.CompoundRootAccessoruses that answer to choose the value stack object that takes a parameter. It now only offers a parameter to an object that can actually take it.Changes
ognl.version3.4.14 → 3.4.15ParametersInterceptorTest#testModelDrivenFinalFieldDoesNotTakeParameterpins the new behaviour for a ModelDriven action. It fails on 3.4.14 and passes on 3.4.15.Test plan
🤖 Generated with Claude Code