Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ Release Notes.
9.8.0
------------------

* Fix the `spring-ai-1.x-plugin` `ChatModelStreamInterceptor` leaking its async span when
`ChatModel#stream(Prompt)` fails synchronously, which silently dropped the whole `TraceSegment`
of the request (apache/skywalking#14098).
* Fix `jedis-4.x-plugin`'s `AbstractConnectionInterceptor` double-stopping the span stack on any
Redis-level exception (or a null dynamic field on a pooled/recycled `Connection`), which corrupted
the parent trace for the rest of the request (apache/skywalking#14085).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA
return ret;
}

if (!(ret instanceof Flux)) {
ContextManager.stopSpan();
return ret;
}

final AbstractSpan span = ContextManager.activeSpan();
final ContextSnapshot snapshot = ContextManager.capture();

Expand Down
Loading