Skip to content

MINOR: DirectCodecFactory does not need to support past versions of Hadoop - #3917

Open
dossett wants to merge 2 commits into
apache:masterfrom
dossett:directcodechadoop
Open

dossett wants to merge 2 commits into
apache:masterfrom
dossett:directcodechadoop

Conversation

@dossett

@dossett dossett commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

11 years ago we needed this, but not anymore since we only support Hadoop 3.x. DirectCodecFactory is package private so these are not breaking changes.

@Fokko Fokko changed the title [minor] DirectCodecFactory does not need to support past versions of Hadoop MINOR: DirectCodecFactory does not need to support past versions of Hadoop Nov 1, 2026
@Fokko

Fokko commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Looks like this changes a return type:

[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.26.5:cmp (default) on project parquet-hadoop: There is at least one incompatibility: org.apache.parquet.hadoop.DirectCodecFactory$DirectCodecPool$CodecPool.borrowDirectDecompressor():METHOD_RETURN_TYPE_CHANGED -> [Help 1]

@dossett

dossett commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Interesting! japicmp is being perhaps a little aggressive here since the method is a public class inside a package private class. But then again, that inner class should not really be public. Correcting that would itself be another japicmp warning, so I just fixed the changed return type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants